Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 16917002: Rename chromium-win* ports to win* (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/factory.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/Tools/Scripts/webkitpy/layout_tests/port/factory.py
index e23f6e8b2a9769c9aaafcc1b6fc90a320b38a4eb..1941a8758900281c4105c54ae4a9a8cc19ef11e1 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/factory.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/factory.py
@@ -75,7 +75,7 @@ class PortFactory(object):
'chromium_android.ChromiumAndroidPort',
'chromium_linux.ChromiumLinuxPort',
'chromium_mac.ChromiumMacPort',
- 'chromium_win.ChromiumWinPort',
+ 'win.WinPort',
'mock_drt.MockDRTPort',
'test.TestPort',
)
@@ -90,7 +90,7 @@ class PortFactory(object):
elif platform.is_mac():
return 'chromium-mac'
elif platform.is_win():
- return 'chromium-win'
+ return 'win'
raise NotImplementedError('unknown platform: %s' % platform)
def get(self, port_name=None, options=None, **kwargs):
@@ -103,7 +103,12 @@ class PortFactory(object):
# with '--platform chromium-mac' and '--platform chromium-linux' properly (we
# can't look at the port_name prefix in this case).
if port_name == 'chromium':
- port_name = 'chromium-' + self._host.platform.os_name
+ # FIXME(steveblock): This hack will go away once all ports have
+ # been renamed to remove the 'chromium-' part.
+ if self._host.platform.os_name == 'win':
+ port_name = 'win'
+ else:
+ port_name = 'chromium-' + self._host.platform.os_name
for port_class in self.PORT_CLASSES:
module_name, class_name = port_class.rsplit('.', 1)

Powered by Google App Engine
This is Rietveld 408576698