Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1690903003: Remove support for Javascript warnings in the VM. (Closed)

Created:
4 years, 10 months ago by regis
Modified:
4 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove support for Javascript warnings in the VM. This cl is a clone of cl https://codereview.chromium.org/1683363002/ deleted by accident. Already LGTM'ed. Committed: https://github.com/dart-lang/sdk/commit/bb649318e445797f28565cda990af62b2256b582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1291 lines) Patch
M runtime/lib/errors_patch.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/lib/identical.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/lib/integers.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M runtime/lib/math_patch.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/lib/object.cc View 4 chunks +0 lines, -47 lines 0 comments Download
M runtime/lib/timeline.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M runtime/vm/exceptions.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/exceptions.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 4 chunks +34 lines, -66 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +3 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 10 chunks +0 lines, -41 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 6 chunks +0 lines, -41 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 15 chunks +0 lines, -62 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M runtime/vm/object.h View 7 chunks +4 lines, -21 lines 0 comments Download
M runtime/vm/object.cc View 9 chunks +3 lines, -89 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +26 lines, -40 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/report.h View 3 chunks +0 lines, -23 lines 0 comments Download
M runtime/vm/report.cc View 4 chunks +0 lines, -105 lines 0 comments Download
D runtime/vm/report_test.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D tests/standalone/javascript_compatibility_errors_test.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D tests/standalone/javascript_compatibility_warnings_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/standalone/javascript_int_overflow_literal_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/standalone/javascript_int_overflow_test.dart View 1 chunk +0 lines, -151 lines 0 comments Download
M tests/standalone/standalone.status View 9 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
regis
4 years, 10 months ago (2016-02-11 17:16:11 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bb649318e445797f28565cda990af62b2256b582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698