Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: runtime/vm/report.h

Issue 1690903003: Remove support for Javascript warnings in the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/report.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report.h
diff --git a/runtime/vm/report.h b/runtime/vm/report.h
index 3cf48ac3a12afe772ad7cdf35dbd42eed8ebd439..f95cb84278821c01d149f76cc13fe1d2031055eb 100644
--- a/runtime/vm/report.h
+++ b/runtime/vm/report.h
@@ -22,7 +22,6 @@ class Report : AllStatic {
public:
enum Kind {
kWarning,
- kJSWarning,
kError,
kMalformedType,
kMalboundedType,
@@ -55,23 +54,6 @@ class Report : AllStatic {
bool report_after_token,
const char* format, va_list args);
- // Support to report Javascript compatibility warnings. Note that a
- // JavascriptCompatibilityError is thrown if --warning_as_error is specified.
- // If a warning is issued by the various JSWarning calls, the warning is also
- // emitted in the trace buffer of the current isolate.
-
- // Report a Javascript compatibility warning at the call site given by
- // ic_data, unless one has already been emitted at that location.
- static void JSWarningFromIC(const ICData& ic_data, const char* msg);
-
- // Report a Javascript compatibility warning at the current native call,
- // unless one has already been emitted at that location.
- static void JSWarningFromNative(bool is_static_native, const char* msg);
-
- // Report a Javascript compatibility warning at the call site given by
- // caller_frame.
- static void JSWarningFromFrame(StackFrame* caller_frame, const char* msg);
-
// Prepend a source snippet to the message.
// A null script means no source and a negative token_pos means no position.
static RawString* PrependSnippet(Kind kind,
@@ -81,11 +63,6 @@ class Report : AllStatic {
const String& message);
private:
- // Emit a Javascript compatibility warning to the current trace buffer.
- static void TraceJSWarning(const Script& script,
- TokenPosition token_pos,
- const String& message);
-
DISALLOW_COPY_AND_ASSIGN(Report);
};
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698