Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: runtime/vm/object.h

Issue 1690903003: Remove support for Javascript warnings in the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 16a129e25b3dc3c7ca4aa5ff416bf74775df5dab..2697e515c06b63ae0de8d76892855f760ae1ceb5 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -1841,13 +1841,6 @@ class ICData : public Object {
bool HasDeoptReason(ICData::DeoptReasonId reason) const;
void AddDeoptReason(ICData::DeoptReasonId reason) const;
- bool IssuedJSWarning() const;
- void SetIssuedJSWarning() const;
-
- // Return true if the target function of this IC data may check for (and
- // possibly issue) a Javascript compatibility warning.
- bool MayCheckForJSWarning() const;
-
intptr_t NumberOfChecks() const;
// Discounts any checks with usage of zero.
@@ -2036,7 +2029,7 @@ class ICData : public Object {
}
}
- // It is only meaningful to interptret range feedback stored in the ICData
+ // It is only meaningful to interpret range feedback stored in the ICData
// when all checks are Mint or Smi.
bool HasRangeFeedback() const;
RangeFeedback DecodeRangeFeedbackAt(intptr_t idx) const;
@@ -2075,8 +2068,7 @@ class ICData : public Object {
kNumArgsTestedSize = 2,
kDeoptReasonPos = kNumArgsTestedPos + kNumArgsTestedSize,
kDeoptReasonSize = kLastRecordedDeoptReason + 1,
- kIssuedJSWarningBit = kDeoptReasonPos + kDeoptReasonSize,
- kRangeFeedbackPos = kIssuedJSWarningBit + 1,
+ kRangeFeedbackPos = kDeoptReasonPos + kDeoptReasonSize,
kRangeFeedbackSize = kBitsPerRangeFeedback * kRangeFeedbackSlots
};
@@ -2088,8 +2080,6 @@ class ICData : public Object {
uint32_t,
ICData::kDeoptReasonPos,
ICData::kDeoptReasonSize> {};
- class IssuedJSWarningBit :
- public BitField<uint32_t, bool, kIssuedJSWarningBit, 1> {};
class RangeFeedbackBits : public BitField<uint32_t,
uint32_t,
ICData::kRangeFeedbackPos,
@@ -5967,10 +5957,7 @@ class Integer : public Number {
// Returns a canonical Integer object allocated in the old gen space.
static RawInteger* NewCanonical(const String& str);
- // Do not throw JavascriptIntegerOverflow if 'silent' is true.
- static RawInteger* New(int64_t value,
- Heap::Space space = Heap::kNew,
- const bool silent = false);
+ static RawInteger* New(int64_t value, Heap::Space space = Heap::kNew);
virtual bool OperatorEquals(const Instance& other) const {
return Equals(other);
@@ -6008,9 +5995,6 @@ class Integer : public Number {
const Integer& other,
Heap::Space space = Heap::kNew) const;
- // Returns true if the Integer does not fit in a Javascript integer.
- bool CheckJavascriptIntegerOverflow() const;
-
private:
OBJECT_IMPLEMENTATION(Integer, Number);
friend class Class;
@@ -6067,8 +6051,7 @@ class Smi : public Integer {
RawInteger* ShiftOp(Token::Kind kind,
const Smi& other,
- Heap::Space space = Heap::kNew,
- const bool silent = false) const;
+ Heap::Space space = Heap::kNew) const;
void operator=(RawSmi* value) {
raw_ = value;
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698