Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1690903003: Remove support for Javascript warnings in the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index be7171a524c6ad4c091ab8b9d3a4c8f86e314917..3113ca37d6cd14871fc8e98cb1b9cf2b51470407 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -43,7 +43,6 @@ DEFINE_FLAG(bool, fields_may_be_reset, false,
"Don't optimize away static field initialization");
DECLARE_FLAG(bool, eliminate_type_checks);
DECLARE_FLAG(bool, trace_optimization);
-DECLARE_FLAG(bool, throw_on_javascript_int_overflow);
Definition::Definition(intptr_t deopt_id)
: Instruction(deopt_id),
@@ -1323,11 +1322,6 @@ bool BinaryInt32OpInstr::CanDeoptimize() const {
bool BinarySmiOpInstr::CanDeoptimize() const {
- if (FLAG_throw_on_javascript_int_overflow && (Smi::kBits > 32)) {
- // If Smi's are bigger than 32-bits, then the instruction could deoptimize
- // if the result is too big.
- return true;
- }
switch (op_kind()) {
case Token::kBIT_AND:
case Token::kBIT_OR:
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698