Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, yusukes+watch_chromium.org, kinuko+watch, feature-media-reviews_chromium.org, tzik+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*" Android fixes and post-Linux cleanup BUG=110610 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206179

Patch Set 1 #

Patch Set 2 : Format tweak #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : rebased #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -100 lines) Patch
M android_webview/browser/aw_browser_context.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M android_webview/browser/aw_form_database_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/android/edge_effect.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/surface_texture_peer_browser_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/data_fetcher_impl_android.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/location_api_adapter_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/surface_texture_transport_client_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/stream_texture_factory_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_unittests_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 16 chunks +35 lines, -34 lines 0 comments Download
M net/ssl/openssl_client_key_store_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-13 00:32:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16907002/2001
7 years, 6 months ago (2013-06-13 00:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16907002/2001
7 years, 6 months ago (2013-06-13 04:06:58 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 07:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16907002/32001
7 years, 6 months ago (2013-06-13 17:32:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=17873
7 years, 6 months ago (2013-06-13 18:11:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16907002/47001
7 years, 6 months ago (2013-06-13 18:14:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests, content_browsertests, content_unittests, nacl_integration, sql_unittests, sync_integration_tests, ...
7 years, 6 months ago (2013-06-13 20:22:40 UTC) #8
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-13 20:37:28 UTC) #9
Ryan Sleevi
7 years, 6 months ago (2013-06-13 22:42:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #6 manually as r206179 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698