content/browser/geolocation/location_api_adapter_android.cc - Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/location_api_adapter_android.cc

Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_orientation/data_fetcher_impl_android.cc ('k') | content/browser/renderer_host/java/java_bridge_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/location_api_adapter_android.cc

diff --git a/content/browser/geolocation/location_api_adapter_android.cc b/content/browser/geolocation/location_api_adapter_android.cc

index 7d015029dfe5f3ef968bd8e87f7056e845991d92..3ab693b33d16b2c1c4c9f2fdaec0ee5475feafa2 100644

--- a/content/browser/geolocation/location_api_adapter_android.cc

+++ b/content/browser/geolocation/location_api_adapter_android.cc

@@ -41,7 +41,7 @@ AndroidLocationApiAdapter::AndroidLocationApiAdapter()

AndroidLocationApiAdapter::~AndroidLocationApiAdapter() {

CHECK(!location_provider_);

- CHECK(!message_loop_);

+ CHECK(!message_loop_.get());

CHECK(java_location_provider_android_object_.is_null());

}

@@ -151,7 +151,7 @@ void AndroidLocationApiAdapter::CreateJavaObject(JNIEnv* env) {

void AndroidLocationApiAdapter::OnNewGeopositionInternal(

const Geoposition& geoposition) {

base::AutoLock lock(lock_);

- if (!message_loop_)

+ if (!message_loop_.get())

return;

message_loop_->PostTask(

FROM_HERE,