android_webview/native/aw_http_auth_handler.cc - Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_http_auth_handler.cc

Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/android_stream_reader_url_request_job.cc ('k') | android_webview/native/cookie_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_http_auth_handler.cc

diff --git a/android_webview/native/aw_http_auth_handler.cc b/android_webview/native/aw_http_auth_handler.cc

index 8bcebbaa28075fcf2b70f2890ea49a07b7f60e67..5ff4df989d51b9216c65202d7515859c5f77020c 100644

--- a/android_webview/native/aw_http_auth_handler.cc

+++ b/android_webview/native/aw_http_auth_handler.cc

@@ -41,7 +41,7 @@ void AwHttpAuthHandler::Proceed(JNIEnv* env,

jstring user,

jstring password) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

- if (login_delegate_) {

+ if (login_delegate_.get()) {

login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user),

ConvertJavaStringToUTF16(env, password));

login_delegate_ = NULL;

@@ -50,7 +50,7 @@ void AwHttpAuthHandler::Proceed(JNIEnv* env,

void AwHttpAuthHandler::Cancel(JNIEnv* env, jobject obj) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

- if (login_delegate_) {

+ if (login_delegate_.get()) {

login_delegate_->Cancel();

login_delegate_ = NULL;

}

« no previous file with comments | « android_webview/browser/net/android_stream_reader_url_request_job.cc ('k') | android_webview/native/cookie_manager.cc » ('j') | no next file with comments »