content/browser/device_orientation/data_fetcher_impl_android.cc - Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/data_fetcher_impl_android.cc

Issue 16907002: Update Android to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/surface_texture_peer_browser_impl.cc ('k') | content/browser/geolocation/location_api_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/data_fetcher_impl_android.cc

diff --git a/content/browser/device_orientation/data_fetcher_impl_android.cc b/content/browser/device_orientation/data_fetcher_impl_android.cc

index def5d8a3d7e807213c04be86a2f7fc638eda7b17..069454db1d7faafc243b2bf02287c1148eab600d 100644

--- a/content/browser/device_orientation/data_fetcher_impl_android.cc

+++ b/content/browser/device_orientation/data_fetcher_impl_android.cc

@@ -59,11 +59,11 @@ const Orientation* DataFetcherImplAndroid::GetOrientation() {

// Do we have a new orientation value? (It's safe to do this outside the lock

// because we only skip the lock if the value is null. We always enter the

// lock if we're going to make use of the new value.)

- if (next_orientation_) {

+ if (next_orientation_.get()) {

base::AutoLock autolock(next_orientation_lock_);

next_orientation_.swap(current_orientation_);

}

- if (!current_orientation_)

+ if (!current_orientation_.get())

return new Orientation();

return current_orientation_.get();

}