Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1689703002: Finalize gpu shaders in ProgramBuilding. (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 10 months ago (2016-02-10 17:08:58 UTC) #3
joshualitt
On 2016/02/10 17:08:58, egdaniel wrote: lgtm
4 years, 10 months ago (2016-02-10 17:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689703002/1
4 years, 10 months ago (2016-02-10 17:15:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 17:50:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9f1d4151ee35c1d2d4345fee2fbaf7b4210fb37d

Powered by Google App Engine
This is Rietveld 408576698