Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 16896019: Replace RenderArena with PartitionAlloc. (Closed)

Created:
7 years ago by Chris Evans
Modified:
6 years, 12 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, caseq+blink_chromium.org, chromiumbugtracker_adobe.com, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, darktears, vcarbune.chromium, feature-media-reviews_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, jeez
Visibility:
Public.

Description

Replace RenderArena with PartitionAlloc. This is a significant code clean-up. In terms of performance, it seems roughly a wash. Memory usage, however, seems improved. The new allocator releases pages back to the system, and is an improvement for cases where the render tree is large but then shrinks during the lifetime of the Document. See the bug for details of tests run and results. BUG=252057

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -1154 lines) Patch
M Source/WebKit/chromium/tests/RenderTableCellTest.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/tests/RenderTableRowTest.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/Init.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/dom/Document.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 6 chunks +2 lines, -11 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +2 lines, -18 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/BaseButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/BaseButtonInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAppletElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLBRElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBRElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HiddenInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HiddenInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/InputType.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TextFieldInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DetailsMarkerControl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DetailsMarkerControl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MeterShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MeterShadowElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/TextFieldDecorationElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextFieldDecorationElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M Source/core/page/FrameView.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M Source/core/page/Page.h View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
D Source/core/platform/Arena.h View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/platform/Arena.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
A + Source/core/platform/Partitions.h View 1 chunk +11 lines, -15 lines 0 comments Download
A + Source/core/platform/Partitions.cpp View 1 chunk +13 lines, -5 lines 0 comments Download
M Source/core/rendering/BidiRun.h View 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/rendering/BidiRun.cpp View 2 chunks +8 lines, -22 lines 0 comments Download
M Source/core/rendering/InlineBox.h View 3 chunks +8 lines, -13 lines 0 comments Download
M Source/core/rendering/InlineBox.cpp View 4 chunks +10 lines, -24 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/InlineIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/LayoutState.h View 3 chunks +7 lines, -9 lines 0 comments Download
M Source/core/rendering/LayoutState.cpp View 2 chunks +8 lines, -18 lines 0 comments Download
D Source/core/rendering/RenderArena.h View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/core/rendering/RenderArena.cpp View 1 chunk +0 lines, -170 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 10 chunks +10 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 11 chunks +13 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 7 chunks +6 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 4 chunks +9 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLineBoxList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLineBoxList.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 3 chunks +7 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 6 chunks +28 lines, -41 lines 1 comment Download
M Source/core/rendering/RenderQuote.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplica.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRubyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRubyRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderWidget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderWidgetProtector.h View 1 chunk +2 lines, -3 lines 1 comment Download
M Source/core/rendering/RootInlineBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 4 chunks +7 lines, -10 lines 0 comments Download
M Source/core/rendering/style/ContentData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDefsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGStopElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledTransformableElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyledTransformableElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTRefElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTSpanElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTSpanElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/PartitionAlloc.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/PartitionAlloc.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Chris Evans
Looks horrific but is mostly mechanical. Most of the files touched only have characters removed.
7 years ago (2013-06-20 01:21:21 UTC) #1
abarth-chromium
LGTM You've written this CL in a way that's going to be hard to revert ...
7 years ago (2013-06-20 01:39:50 UTC) #2
esprehn
I don't think this is a good change. The render tree needs to be packed ...
7 years ago (2013-06-20 09:15:43 UTC) #3
esprehn
On 2013/06/20 09:15:43, esprehn wrote: > ... > > https://codereview.chromium.org/16896019/diff/1/Source/core/rendering/RenderObject.cpp#newcode122 > Source/core/rendering/RenderObject.cpp:122: return > partitionAlloc(Partitions::getRenderingPartition(), ...
7 years ago (2013-06-20 09:20:28 UTC) #4
abarth-chromium
On 2013/06/20 09:20:28, esprehn wrote: > Ojan and others have expressed the importance of keeping ...
7 years ago (2013-06-20 15:57:48 UTC) #5
Chris Evans
On 2013/06/20 15:57:48, abarth wrote: > On 2013/06/20 09:20:28, esprehn wrote: > > Ojan and ...
7 years ago (2013-06-20 17:48:50 UTC) #6
ojan
This landed in a different patch, right? Can we close this issue?
6 years, 12 months ago (2013-07-16 00:56:24 UTC) #7
esprehn
On 2013/07/16 00:56:24, ojan wrote: > This landed in a different patch, right? Can we ...
6 years, 12 months ago (2013-07-16 01:01:13 UTC) #8
cevans
6 years, 12 months ago (2013-07-17 09:23:16 UTC) #9
On 2013/07/16 01:01:13, esprehn wrote:
> On 2013/07/16 00:56:24, ojan wrote:
> > This landed in a different patch, right? Can we close this issue?
> 
> We never landed this entire patch, we landed a big chunk of this though I
think?
> I thought cevans was going to see what his patch did for the perf tests, maybe
> we should just land the final bits and see what the graphs do!

That's right, we landed some of the prep work for this patch but nothing that
changes behaviour yet. The actual switch is pending a couple more performance
measurements that Elliot and I talked about; they're documented in the bug. I'll
finish off the work here when I'm back from vacation.

Powered by Google App Engine
This is Rietveld 408576698