Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 16896019: Replace RenderArena with PartitionAlloc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 if (renderer()) 327 if (renderer())
328 return isFocusable(); 328 return isFocusable();
329 return HTMLFormControlElementWithState::isMouseFocusable(); 329 return HTMLFormControlElementWithState::isMouseFocusable();
330 } 330 }
331 331
332 bool HTMLSelectElement::canSelectAll() const 332 bool HTMLSelectElement::canSelectAll() const
333 { 333 {
334 return !usesMenuList(); 334 return !usesMenuList();
335 } 335 }
336 336
337 RenderObject* HTMLSelectElement::createRenderer(RenderArena* arena, RenderStyle* ) 337 RenderObject* HTMLSelectElement::createRenderer(RenderStyle*)
338 { 338 {
339 if (usesMenuList()) 339 if (usesMenuList())
340 return new (arena) RenderMenuList(this); 340 return new RenderMenuList(this);
341 return new (arena) RenderListBox(this); 341 return new RenderListBox(this);
342 } 342 }
343 343
344 bool HTMLSelectElement::childShouldCreateRenderer(const NodeRenderingContext& ch ildContext) const 344 bool HTMLSelectElement::childShouldCreateRenderer(const NodeRenderingContext& ch ildContext) const
345 { 345 {
346 if (!HTMLFormControlElementWithState::childShouldCreateRenderer(childContext )) 346 if (!HTMLFormControlElementWithState::childShouldCreateRenderer(childContext ))
347 return false; 347 return false;
348 if (!usesMenuList()) 348 if (!usesMenuList())
349 return childContext.node()->hasTagName(HTMLNames::optionTag) || childCon text.node()->hasTagName(HTMLNames::optgroupTag); 349 return childContext.node()->hasTagName(HTMLNames::optionTag) || childCon text.node()->hasTagName(HTMLNames::optgroupTag);
350 return false; 350 return false;
351 } 351 }
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 { 1577 {
1578 if (!value) { 1578 if (!value) {
1579 ec = TYPE_MISMATCH_ERR; 1579 ec = TYPE_MISMATCH_ERR;
1580 return false; 1580 return false;
1581 } 1581 }
1582 setOption(index, value.get(), ec); 1582 setOption(index, value.get(), ec);
1583 return true; 1583 return true;
1584 } 1584 }
1585 1585
1586 } // namespace 1586 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698