content/shell/renderer/layout_test/layout_test_render_frame_observer.h - Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

index 5ce62f0d582fc6d09c254751248376b9d1ece2f6..da675be41790259225c0f61e88d77bb0da1fc6a1 100644

--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

@@ -6,9 +6,12 @@

#define CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_

#include "base/macros.h"

-#include "components/test_runner/layout_dump_flags.h"

#include "content/public/renderer/render_frame_observer.h"

+namespace test_runner {

+struct LayoutDumpFlags;

namespace IPC {

class Message;

} // namespace IPC

@@ -24,7 +27,8 @@ class LayoutTestRenderFrameObserver : public RenderFrameObserver {

bool OnMessageReceived(const IPC::Message& message) override;

private:

- void OnLayoutDumpRequest(test_runner::LayoutDumpFlags layout_dump_flags);

+ void OnLayoutDumpRequest(

+ const test_runner::LayoutDumpFlags& layout_dump_flags);

DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);

};