content/shell/renderer/layout_test/layout_test_render_frame_observer.cc - Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

index 6cf65a812d75c2145b1473ff7f4b174695cff67d..cf514295209717453ebe0a7ca2c3fb91bf93ef98 100644

--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

@@ -40,7 +40,7 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(

}

void LayoutTestRenderFrameObserver::OnLayoutDumpRequest(

- test_runner::LayoutDumpFlags layout_dump_flags) {

+ const test_runner::LayoutDumpFlags& layout_dump_flags) {

std::string dump =

test_runner::DumpLayout(render_frame()->GetWebFrame(), layout_dump_flags);

Send(new ShellViewHostMsg_LayoutDumpResponse(routing_id(), dump));

« no previous file with comments | « content/shell/renderer/layout_test/layout_test_render_frame_observer.h ('k') | no next file » | no next file with comments »