content/shell/renderer/layout_test/blink_test_runner.cc - Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/blink_test_runner.cc

diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc

index 30310746ef654f6a12dfda52c47180307fe9626b..20bc8b44957f65e26c7670b6081a2ffc7da7166c 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.cc

+++ b/content/shell/renderer/layout_test/blink_test_runner.cc

@@ -892,7 +892,7 @@ void BlinkTestRunner::CaptureDump() {

base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDumpLineBoxTrees);

- if (!layout_dump_flags.dump_child_frames) {

+ if (!layout_dump_flags.dump_child_frames()) {

std::string layout_dump = DumpLayout(

render_view()->GetMainRenderFrame()->GetWebFrame(), layout_dump_flags);

OnLayoutDumpCompleted(layout_dump);

« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.h » ('j') | no next file with comments »