Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_
6 #define CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_ 6 #define CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/test_runner/layout_dump_flags.h"
10 #include "content/public/renderer/render_frame_observer.h" 9 #include "content/public/renderer/render_frame_observer.h"
11 10
11 namespace test_runner {
12 struct LayoutDumpFlags;
13 }
14
12 namespace IPC { 15 namespace IPC {
13 class Message; 16 class Message;
14 } // namespace IPC 17 } // namespace IPC
15 18
16 namespace content { 19 namespace content {
17 class RenderFrame; 20 class RenderFrame;
18 21
19 class LayoutTestRenderFrameObserver : public RenderFrameObserver { 22 class LayoutTestRenderFrameObserver : public RenderFrameObserver {
20 public: 23 public:
21 explicit LayoutTestRenderFrameObserver(RenderFrame* render_frame); 24 explicit LayoutTestRenderFrameObserver(RenderFrame* render_frame);
22 ~LayoutTestRenderFrameObserver() override {} 25 ~LayoutTestRenderFrameObserver() override {}
23 26
24 bool OnMessageReceived(const IPC::Message& message) override; 27 bool OnMessageReceived(const IPC::Message& message) override;
25 28
26 private: 29 private:
27 void OnLayoutDumpRequest(test_runner::LayoutDumpFlags layout_dump_flags); 30 void OnLayoutDumpRequest(
31 const test_runner::LayoutDumpFlags& layout_dump_flags);
28 32
29 DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver); 33 DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);
30 }; 34 };
31 35
32 } // namespace content 36 } // namespace content
33 37
34 #endif // CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_ H_ 38 #endif // CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698