Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1687553002: Change all ARM calls into indirect calls. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change ARM calls into indirect calls. This is done by putting far pointers (for calls) into a register and then do an indirect call. This was done to guarantee that we aren't putting a size limit on ARM32 executables. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d91cbbfadce6ab8836bdd8d65054c9381e9043c2

Patch Set 1 #

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+765 lines, -381 lines) Patch
M src/IceTargetLoweringARM32.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
A tests_lit/assembler/arm32/call.ll View 1 1 chunk +45 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/push-pop.ll View 2 chunks +32 lines, -123 lines 0 comments Download
M tests_lit/assembler/arm32/sandboxing.ll View 2 chunks +271 lines, -81 lines 0 comments Download
M tests_lit/assembler/arm32/vpush.ll View 2 chunks +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 11 chunks +44 lines, -20 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 7 chunks +22 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith.ll View 6 chunks +27 lines, -16 lines 0 comments Download
M tests_lit/llvm2ice_tests/bool-folding.ll View 2 chunks +6 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 7 chunks +53 lines, -27 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arith.ll View 2 chunks +6 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arm.call.ll View 32 chunks +120 lines, -40 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.cmp.ll View 1 chunk +3 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/large_stack_offs.ll View 3 chunks +13 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll View 28 chunks +83 lines, -29 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 3 chunks +12 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 chunk +12 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Karl
4 years, 10 months ago (2016-02-09 20:13:45 UTC) #3
John
lgtm please use this bug https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
4 years, 10 months ago (2016-02-09 20:29:12 UTC) #4
Karl
Cleaned up the heading.
4 years, 10 months ago (2016-02-09 21:14:27 UTC) #8
Karl
4 years, 10 months ago (2016-02-09 21:20:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d91cbbfadce6ab8836bdd8d65054c9381e9043c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698