Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: tests_lit/llvm2ice_tests/alloc.ll

Issue 1687553002: Change all ARM calls into indirect calls. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests_lit/llvm2ice_tests/64bit.pnacl.ll ('k') | tests_lit/llvm2ice_tests/arith.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests_lit/llvm2ice_tests/alloc.ll
diff --git a/tests_lit/llvm2ice_tests/alloc.ll b/tests_lit/llvm2ice_tests/alloc.ll
index cf0926c8bfea3b346983547bf0547778f6e06cf9..7dadda20730a9f2a5457fed3792053cdc5d58147 100644
--- a/tests_lit/llvm2ice_tests/alloc.ll
+++ b/tests_lit/llvm2ice_tests/alloc.ll
@@ -9,19 +9,16 @@
; RUN: | %if --need=target_X8632 --command FileCheck \
; RUN: --check-prefix CHECK-OPTM1 %s
-; TODO(jvoung): Stop skipping unimplemented parts (via --skip-unimplemented)
-; once enough infrastructure is in. Also, switch to --filetype=obj
-; when possible.
; RUN: %if --need=target_ARM32 --need=allow_dump \
-; RUN: --command %p2i --filetype=asm --assemble \
-; RUN: --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \
+; RUN: --command %p2i --filetype=obj --assemble \
+; RUN: --disassemble --target arm32 -i %s --args -O2 \
; RUN: -allow-externally-defined-symbols \
; RUN: | %if --need=target_ARM32 --need=allow_dump \
; RUN: --command FileCheck --check-prefix ARM32 --check-prefix=ARM-OPT2 %s
; RUN: %if --need=target_ARM32 --need=allow_dump \
-; RUN: --command %p2i --filetype=asm --assemble \
-; RUN: --disassemble --target arm32 -i %s --args -Om1 --skip-unimplemented \
+; RUN: --command %p2i --filetype=obj --assemble \
+; RUN: --disassemble --target arm32 -i %s --args -Om1 \
; RUN: -allow-externally-defined-symbols \
; RUN: | %if --need=target_ARM32 --need=allow_dump \
; RUN: --command FileCheck --check-prefix ARM32 --check-prefix=ARM-OPTM1 %s
@@ -48,7 +45,9 @@ entry:
; ARM32-LABEL: fixed_416_align_16
; ARM32-OPT2: sub sp, sp, #428
; ARM32-OPTM1: sub sp, sp, #416
-; ARM32: bl {{.*}} R_{{.*}} f1
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f1
+; ARM32: movt [[CALL]], {{.+}} f1
+; ARM32: blx [[CALL]]
define internal void @fixed_416_align_32(i32 %n) {
entry:
@@ -70,7 +69,9 @@ entry:
; ARM32-OPT2: sub sp, sp, #424
; ARM32-OPTM1: sub sp, sp, #416
; ARM32: bic sp, sp, #31
-; ARM32: bl {{.*}} R_{{.*}} f1
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f1
+; ARM32: movt [[CALL]], {{.+}} f1
+; ARM32: blx [[CALL]]
; Show that the amount to allocate will be rounded up.
define internal void @fixed_351_align_16(i32 %n) {
@@ -95,7 +96,9 @@ entry:
; ARM32-LABEL: fixed_351_align_16
; ARM32-OPT2: sub sp, sp, #364
; ARM32-OPTM1: sub sp, sp, #352
-; ARM32: bl {{.*}} R_{{.*}} f1
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f1
+; ARM32: movt [[CALL]], {{.+}} f1
+; ARM32: blx [[CALL]]
define internal void @fixed_351_align_32(i32 %n) {
entry:
@@ -117,7 +120,9 @@ entry:
; ARM32-OPT2: sub sp, sp, #360
; ARM32-OPTM1: sub sp, sp, #352
; ARM32: bic sp, sp, #31
-; ARM32: bl {{.*}} R_{{.*}} f1
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f1
+; ARM32: movt [[CALL]], {{.+}} f1
+; ARM32: blx [[CALL]]
declare void @f1(i32 %ignored)
@@ -144,7 +149,9 @@ entry:
; ARM32: add r0, r0, #15
; ARM32: bic r0, r0, #15
; ARM32: sub sp, sp, r0
-; ARM32: bl {{.*}} R_{{.*}} f2
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f2
+; ARM32: movt [[CALL]], {{.+}} f2
+; ARM32: blx [[CALL]]
define internal void @variable_n_align_32(i32 %n) {
entry:
@@ -176,7 +183,9 @@ entry:
; ARM32: add r0, r0, #31
; ARM32: bic r0, r0, #31
; ARM32: sub sp, sp, r0
-; ARM32: bl {{.*}} R_{{.*}} f2
+; ARM32: movw [[CALL:r[0-9]]], {{.+}} f2
+; ARM32: movt [[CALL]], {{.+}} f2
+; ARM32: blx [[CALL]]
; ARM32: mov sp, fp
; ARM32: pop {fp, lr}
« no previous file with comments | « tests_lit/llvm2ice_tests/64bit.pnacl.ll ('k') | tests_lit/llvm2ice_tests/arith.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698