Remove HostDesktopType from AppLaunchParams

Remove HostDesktopType from AppLaunchParams

R=sky@chromium.org, benwells@chromium.org
BUG=558054
Committed: https://crrev.com/99230da5e39ce56f28f05a515941fae53ba5eded
Cr-Commit-Position: refs/heads/master@{#374814}

[scottmg, 2016-02-09 22:50:04]

benwells: apps and extensions files
sky: the rest

https://codereview.chromium.org/1685883003/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/app_launch_params.cc (left):

https://codereview.chromium.org/1685883003/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/app_launch_params.cc:45: // Look up the app
preference to find out the right launch container. Default
This was a bit weird. The constructor that took a HostDesktopType did a bunch of
extra stuff, but that extra stuff is unrelated to |desktop_type|. I kept the one
that did more.

[sky, 2016-02-10 00:02:16]

LGTM

[scottmg, 2016-02-10 21:39:54]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-02-10 21:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685883003/20001

[scottmg, 2016-02-10 22:06:14]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-02-10 22:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1685883003/#ps40001
(title: "mac")

[commit-bot: I haz the power, 2016-02-10 22:09:55]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2016-02-10 22:10:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685883003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685883003/40001

[commit-bot: I haz the power, 2016-02-10 22:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 22:25:31]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-02-10 22:25:57]

Patchset #3 (id:40001) has been deleted

[scottmg, 2016-02-10 23:48:44]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-02-10 23:50:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685883003/20001

[commit-bot: I haz the power, 2016-02-11 01:00:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:33:30]

Description was changed from

==========
Remove HostDesktopType from AppLaunchParams

R=sky@chromium.org, benwells@chromium.org
BUG=558054
==========

to

==========
Remove HostDesktopType from AppLaunchParams

R=sky@chromium.org, benwells@chromium.org
BUG=558054

Committed: https://crrev.com/99230da5e39ce56f28f05a515941fae53ba5eded
Cr-Commit-Position: refs/heads/master@{#374814}
==========

[commit-bot: I haz the power, 2016-02-16 22:33:30]

Patchset 2 (id:??) landed as
https://crrev.com/99230da5e39ce56f28f05a515941fae53ba5eded
Cr-Commit-Position: refs/heads/master@{#374814}

[scottmg, 2016-02-17 17:33:42]

Will try to see if this can revert cleanly.

https://codereview.chromium.org/1685883003/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/app_launch_params.cc (left):

https://codereview.chromium.org/1685883003/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/app_launch_params.cc:45: // Look up the app
preference to find out the right launch container. Default
On 2016/02/09 22:50:04, scottmg (afk on tues feb16) wrote:
> This was a bit weird. The constructor that took a HostDesktopType did a bunch
of
> extra stuff, but that extra stuff is unrelated to |desktop_type|. I kept the
one
> that did more.

It looks like this wasn't right. The two constructor's args are the same except
for the HostDesktopType (which they don't use), but the existence of that
argument was being used as a bool to choose a constructor which did different
things.

I think this likely caused
https://code.google.com/p/chromium/issues/detail?id=587387 and
https://code.google.com/p/chromium/issues/detail?id=586862 .

[scottmg, 2016-02-17 17:34:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1707773002/ by scottmg@chromium.org.

The reason for reverting is: The two AppLaunchParams ctors args are the same
except
for the HostDesktopType (which they don't use), but the existence of that
argument was being used as a bool to choose a constructor which did different
things.

I think this likely caused
https://code.google.com/p/chromium/issues/detail?id=587387 and
https://code.google.com/p/chromium/issues/detail?id=586862 ..