Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1686833003: Remove HostDesktopType from profiles (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tim+watch_chromium.org, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, rginda+watch_chromium.org, plaree+watch_chromium.org, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from profiles R=sky@chromium.org BUG=558054 Committed: https://crrev.com/ff189b63ddf9cb58c6a98d7a2fabe384265c5ea0 Cr-Commit-Position: refs/heads/master@{#374935}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : desktop linux and mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -241 lines) Patch
M chrome/browser/profiles/avatar_menu.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_window.h View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 7 chunks +9 lines, -35 lines 0 comments Download
M chrome/browser/profiles/profile_window_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 8 chunks +8 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 3 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.h View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 7 chunks +11 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_handlers_helper.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/options_handlers_helper.cc View 2 chunks +4 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 11 chunks +9 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
scottmg
4 years, 10 months ago (2016-02-10 00:13:14 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-10 16:23:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686833003/20001
4 years, 10 months ago (2016-02-11 17:33:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/157627) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-11 17:44:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686833003/40001
4 years, 10 months ago (2016-02-11 18:25:29 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 19:47:28 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:36:34 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ff189b63ddf9cb58c6a98d7a2fabe384265c5ea0
Cr-Commit-Position: refs/heads/master@{#374935}

Powered by Google App Engine
This is Rietveld 408576698