Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684843002: Remove HostDesktopType from ShowDefaultBrowserPrompt (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-14
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from ShowDefaultBrowserPrompt R=sky@chromium.org BUG=558054 Committed: https://crrev.com/b711bab19b62f3dc29bec654e6c28b99fb29548d Cr-Commit-Position: refs/heads/master@{#374730}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
scottmg
4 years, 10 months ago (2016-02-09 22:15:56 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-09 23:57:04 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1682183002 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-09 23:59:41 UTC) #5
scottmg
On 2016/02/09 23:59:41, commit-bot: I haz the power wrote: > This CL has an open ...
4 years, 10 months ago (2016-02-10 00:00:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684843002/1
4 years, 10 months ago (2016-02-10 20:27:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684843002/40001
4 years, 10 months ago (2016-02-10 20:39:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-10 21:39:23 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:14 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b711bab19b62f3dc29bec654e6c28b99fb29548d
Cr-Commit-Position: refs/heads/master@{#374730}

Powered by Google App Engine
This is Rietveld 408576698