Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 1685883003: Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-15
Patch Set: cros Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/chrome_pages.h ('k') | chrome/browser/ui/extensions/app_launch_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index 3e16b17a1b210da5e9c9a349e5690aafa53c8ea8..f31ed3a144069c5e8b0ee41e33c0df4487f49af8 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -82,7 +82,6 @@ void NavigateToSingletonTab(Browser* browser, const GURL& url) {
// is created.
void ShowHelpImpl(Browser* browser,
Profile* profile,
- HostDesktopType host_desktop_type,
HelpSource source) {
content::RecordAction(UserMetricsAction("ShowHelpTab"));
#if defined(OS_CHROMEOS) && defined(OFFICIAL_BUILD)
@@ -104,8 +103,7 @@ void ShowHelpImpl(Browser* browser,
default:
NOTREACHED() << "Unhandled help source" << source;
}
- AppLaunchParams params(profile, extension, CURRENT_TAB, host_desktop_type,
- app_launch_source);
+ AppLaunchParams params(profile, extension, CURRENT_TAB, app_launch_source);
OpenApplication(params);
#else
GURL url;
@@ -205,14 +203,11 @@ void ShowConflicts(Browser* browser) {
}
void ShowHelp(Browser* browser, HelpSource source) {
- ShowHelpImpl(
- browser, browser->profile(), browser->host_desktop_type(), source);
+ ShowHelpImpl(browser, browser->profile(), source);
}
-void ShowHelpForProfile(Profile* profile,
- HostDesktopType host_desktop_type,
- HelpSource source) {
- ShowHelpImpl(NULL, profile, host_desktop_type, source);
+void ShowHelpForProfile(Profile* profile, HelpSource source) {
+ ShowHelpImpl(NULL, profile, source);
}
void ShowPolicy(Browser* browser) {
« no previous file with comments | « chrome/browser/ui/chrome_pages.h ('k') | chrome/browser/ui/extensions/app_launch_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698