Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1685713002: Rework UnlinkedPublicName.constMembers. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework UnlinkedPublicName.constMembers. This CL makes the following changes to UnlinkedPublicName.constMembers: - Includes non-const constructors in it. This will allow a future CL to make use of it for redirected constructors. - Omits unnamed constructors from it--they were never used, and just took up extra space. - Renames it to UnlinkedPublicName.members to be consistent with the fact that it no longer just stores const members. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/879749488528960d5eb31a701210cb83761affad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -57 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +32 lines, -29 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-09 19:06:34 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-09 20:20:39 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-09 20:38:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
879749488528960d5eb31a701210cb83761affad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698