Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1685713002: Rework UnlinkedPublicName.constMembers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index 4edd4cd0bf4bab8df487320365a1f3f6711f0fdd..d6210db1fff40d94e18b4eb30dad80dc21ceaeae 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -71,7 +71,7 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
for (VariableDeclaration field in member.fields.variables) {
String name = field.name.name;
if (isPublic(name)) {
- cls.constMembers.add(new UnlinkedPublicNameBuilder(
+ cls.members.add(new UnlinkedPublicNameBuilder(
name: name,
kind: ReferenceKind.propertyAccessor,
numTypeParameters: 0));
@@ -85,17 +85,18 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
!member.isOperator) {
String name = member.name.name;
if (isPublic(name)) {
- cls.constMembers.add(new UnlinkedPublicNameBuilder(
+ cls.members.add(new UnlinkedPublicNameBuilder(
name: name,
kind: ReferenceKind.method,
numTypeParameters:
member.typeParameters?.typeParameters?.length ?? 0));
}
}
- if (member is ConstructorDeclaration && member.constKeyword != null) {
- String name = member.name != null ? member.name.name : '';
+ if (member is ConstructorDeclaration &&
+ member.name != null) {
+ String name = member.name.name;
if (isPublic(name)) {
- cls.constMembers.add(new UnlinkedPublicNameBuilder(
+ cls.members.add(new UnlinkedPublicNameBuilder(
name: name,
kind: ReferenceKind.constructor,
numTypeParameters: 0));
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698