Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: pkg/analyzer/lib/src/summary/prelink.dart

Issue 1685713002: Rework UnlinkedPublicName.constMembers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/public_namespace_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/prelink.dart
diff --git a/pkg/analyzer/lib/src/summary/prelink.dart b/pkg/analyzer/lib/src/summary/prelink.dart
index 82ab7c5323251a47a92818df01ada758d9ddd9c1..cecc936bd2eaa311448793266b971b5c37bb337a 100644
--- a/pkg/analyzer/lib/src/summary/prelink.dart
+++ b/pkg/analyzer/lib/src/summary/prelink.dart
@@ -194,9 +194,9 @@ class _Prelinker {
aggregated.putIfAbsent(name.name, () {
if (name.kind == ReferenceKind.classOrEnum) {
Map<String, _Meaning> namespace = <String, _Meaning>{};
- name.constMembers.forEach((executable) {
- namespace[executable.name] = new _Meaning(unitNum,
- executable.kind, 0, executable.numTypeParameters);
+ name.members.forEach((executable) {
+ namespace[executable.name] = new _Meaning(
+ unitNum, executable.kind, 0, executable.numTypeParameters);
});
return new _ClassMeaning(
unitNum, dependency, name.numTypeParameters, namespace);
@@ -267,15 +267,14 @@ class _Prelinker {
});
cls.executables.forEach((executable) {
ReferenceKind kind = null;
- if (executable.kind == UnlinkedExecutableKind.constructor &&
- executable.isConst) {
+ if (executable.kind == UnlinkedExecutableKind.constructor) {
kind = ReferenceKind.constructor;
} else if (executable.kind ==
UnlinkedExecutableKind.functionOrMethod &&
executable.isStatic) {
kind = ReferenceKind.method;
}
- if (kind != null) {
+ if (kind != null && executable.name.isNotEmpty) {
namespace[executable.name] = new _Meaning(
unitNum, kind, 0, executable.typeParameters.length);
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/public_namespace_computer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698