Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1685713002: Rework UnlinkedPublicName.constMembers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.summary.public_namespace_visitor; 5 library analyzer.src.summary.public_namespace_visitor;
6 6
7 import 'package:analyzer/analyzer.dart'; 7 import 'package:analyzer/analyzer.dart';
8 import 'package:analyzer/src/summary/format.dart'; 8 import 'package:analyzer/src/summary/format.dart';
9 import 'package:analyzer/src/summary/idl.dart'; 9 import 'package:analyzer/src/summary/idl.dart';
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 ReferenceKind.classOrEnum, 64 ReferenceKind.classOrEnum,
65 node.typeParameters?.typeParameters?.length ?? 0); 65 node.typeParameters?.typeParameters?.length ?? 0);
66 if (cls != null) { 66 if (cls != null) {
67 for (ClassMember member in node.members) { 67 for (ClassMember member in node.members) {
68 if (member is FieldDeclaration && 68 if (member is FieldDeclaration &&
69 member.isStatic && 69 member.isStatic &&
70 member.fields.isConst) { 70 member.fields.isConst) {
71 for (VariableDeclaration field in member.fields.variables) { 71 for (VariableDeclaration field in member.fields.variables) {
72 String name = field.name.name; 72 String name = field.name.name;
73 if (isPublic(name)) { 73 if (isPublic(name)) {
74 cls.constMembers.add(new UnlinkedPublicNameBuilder( 74 cls.members.add(new UnlinkedPublicNameBuilder(
75 name: name, 75 name: name,
76 kind: ReferenceKind.propertyAccessor, 76 kind: ReferenceKind.propertyAccessor,
77 numTypeParameters: 0)); 77 numTypeParameters: 0));
78 } 78 }
79 } 79 }
80 } 80 }
81 if (member is MethodDeclaration && 81 if (member is MethodDeclaration &&
82 member.isStatic && 82 member.isStatic &&
83 !member.isGetter && 83 !member.isGetter &&
84 !member.isSetter && 84 !member.isSetter &&
85 !member.isOperator) { 85 !member.isOperator) {
86 String name = member.name.name; 86 String name = member.name.name;
87 if (isPublic(name)) { 87 if (isPublic(name)) {
88 cls.constMembers.add(new UnlinkedPublicNameBuilder( 88 cls.members.add(new UnlinkedPublicNameBuilder(
89 name: name, 89 name: name,
90 kind: ReferenceKind.method, 90 kind: ReferenceKind.method,
91 numTypeParameters: 91 numTypeParameters:
92 member.typeParameters?.typeParameters?.length ?? 0)); 92 member.typeParameters?.typeParameters?.length ?? 0));
93 } 93 }
94 } 94 }
95 if (member is ConstructorDeclaration && member.constKeyword != null) { 95 if (member is ConstructorDeclaration &&
96 String name = member.name != null ? member.name.name : ''; 96 member.name != null) {
97 String name = member.name.name;
97 if (isPublic(name)) { 98 if (isPublic(name)) {
98 cls.constMembers.add(new UnlinkedPublicNameBuilder( 99 cls.members.add(new UnlinkedPublicNameBuilder(
99 name: name, 100 name: name,
100 kind: ReferenceKind.constructor, 101 kind: ReferenceKind.constructor,
101 numTypeParameters: 0)); 102 numTypeParameters: 0));
102 } 103 }
103 } 104 }
104 } 105 }
105 } 106 }
106 } 107 }
107 108
108 @override 109 @override
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 153
153 @override 154 @override
154 visitVariableDeclaration(VariableDeclaration node) { 155 visitVariableDeclaration(VariableDeclaration node) {
155 String name = node.name.name; 156 String name = node.name.name;
156 addNameIfPublic(name, ReferenceKind.topLevelPropertyAccessor, 0); 157 addNameIfPublic(name, ReferenceKind.topLevelPropertyAccessor, 0);
157 if (!node.isFinal && !node.isConst) { 158 if (!node.isFinal && !node.isConst) {
158 addNameIfPublic('$name=', ReferenceKind.topLevelPropertyAccessor, 0); 159 addNameIfPublic('$name=', ReferenceKind.topLevelPropertyAccessor, 0);
159 } 160 }
160 } 161 }
161 } 162 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698