Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

BUG=none

Committed: https://crrev.com/0cb852e886746830b48c09b426705b23c6845d4c
Cr-Commit-Position: refs/heads/master@{#374826}

[mattm, 2016-02-10 02:56:16]

mattm@chromium.org changed reviewers:
+ eroman@chromium.org

[mattm, 2016-02-10 02:56:16]

ParseExtension strips the OCTET STRING, but the NameConstraints was written
before the Extension parsing code was written and so guessed the wrong way. It
makes more sense to have it stripped, so updated NameConstraints to expect that.

[eroman, 2016-02-10 17:30:09]

lgtm

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
File net/cert/internal/name_constraints.h (right):

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
net/cert/internal/name_constraints.h:89: // sequence.
|subject_alt_name_extnvalue_tlv| should be the extnValue of the
Update this line to reflect new variable name.

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
net/cert/internal/name_constraints.h:91: // empty if the cert did not have a
subjectAltName extension.
This line also needs updating (since that is now conveyed by the bool)

https://codereview.chromium.org/1685023002/diff/1/net/data/name_constraints_u...
File net/data/name_constraints_unittest/san-permitted.pem (right):

https://codereview.chromium.org/1685023002/diff/1/net/data/name_constraints_u...
net/data/name_constraints_unittest/san-permitted.pem:1: 0:d=0  hl=2 l=  64 cons:
SEQUENCE
A nice consequence of this change is this pretty prints better now :)

[mattm, 2016-02-10 22:48:40]

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
File net/cert/internal/name_constraints.h (right):

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
net/cert/internal/name_constraints.h:89: // sequence.
|subject_alt_name_extnvalue_tlv| should be the extnValue of the
On 2016/02/10 17:30:09, eroman wrote:
> Update this line to reflect new variable name.

Done.

https://codereview.chromium.org/1685023002/diff/1/net/cert/internal/name_cons...
net/cert/internal/name_constraints.h:91: // empty if the cert did not have a
subjectAltName extension.
On 2016/02/10 17:30:09, eroman wrote:
> This line also needs updating (since that is now conveyed by the bool)

Done.

https://codereview.chromium.org/1685023002/diff/1/net/data/name_constraints_u...
File net/data/name_constraints_unittest/san-permitted.pem (right):

https://codereview.chromium.org/1685023002/diff/1/net/data/name_constraints_u...
net/data/name_constraints_unittest/san-permitted.pem:1: 0:d=0  hl=2 l=  64 cons:
SEQUENCE
On 2016/02/10 17:30:09, eroman wrote:
> A nice consequence of this change is this pretty prints better now :)

Yep :)

[eroman, 2016-02-10 23:56:43]

lgtm

[mattm, 2016-02-11 00:07:43]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-02-11 00:08:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1685023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1685023002/20001

[commit-bot: I haz the power, 2016-02-11 01:31:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:33:47]

Description was changed from

==========
Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param
and ParseExtension.

BUG=none
==========

to

==========
Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param
and ParseExtension.

BUG=none

Committed: https://crrev.com/0cb852e886746830b48c09b426705b23c6845d4c
Cr-Commit-Position: refs/heads/master@{#374826}
==========

[commit-bot: I haz the power, 2016-02-16 22:33:48]

Patchset 2 (id:??) landed as
https://crrev.com/0cb852e886746830b48c09b426705b23c6845d4c
Cr-Commit-Position: refs/heads/master@{#374826}