net/data/name_constraints_unittest/san-invalid-ipaddress.pem - Issue 1685023002: Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/name_constraints_unittest/san-invalid-ipaddress.pem

Issue 1685023002: Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@name-constraints-directorynameparsing

Patch Set: updated comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/name_constraints_unittest/san-invalid-empty.pem ('k') | net/data/name_constraints_unittest/san-othername.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/name_constraints_unittest/san-invalid-ipaddress.pem

diff --git a/net/data/name_constraints_unittest/san-invalid-ipaddress.pem b/net/data/name_constraints_unittest/san-invalid-ipaddress.pem

index 2a45350c8bc877f56c1d1d21e1dbc407c35808a4..02e4e62b5910016da5936446f5142233a00199c4 100644

--- a/net/data/name_constraints_unittest/san-invalid-ipaddress.pem

+++ b/net/data/name_constraints_unittest/san-invalid-ipaddress.pem

@@ -1,4 +1,5 @@

- 0:d=0 hl=2 l= 9 prim: OCTET STRING [HEX DUMP]:30078705C0A8000500

+ 0:d=0 hl=2 l= 7 cons: SEQUENCE

+ 2:d=1 hl=2 l= 5 prim: cont [ 7 ]

-----BEGIN SUBJECT ALTERNATIVE NAME-----

-BAkwB4cFwKgABQA=

+MAeHBcCoAAUA

-----END SUBJECT ALTERNATIVE NAME-----

« no previous file with comments | « net/data/name_constraints_unittest/san-invalid-empty.pem ('k') | net/data/name_constraints_unittest/san-othername.pem » ('j') | no next file with comments »