Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1686003002: Fix GeneralName directoryName parsing in new (unused) name constraints code. (Closed)

Created:
4 years, 10 months ago by mattm
Modified:
4 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GeneralName directoryName parsing in new (unused) name constraints code. The explicit sequence tag on the Name was not being stripped. BUG=none Committed: https://crrev.com/db034aaf2a2e25138caaff2b5fa1f642460e3d62 Cr-Commit-Position: refs/heads/master@{#374795}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
mattm
Found this when I started playing with enabling the PKITS name constraints tests.
4 years, 10 months ago (2016-02-10 02:37:43 UTC) #2
eroman
lgtm. But please update the CL before landing to explain the actual problem (strip explicit ...
4 years, 10 months ago (2016-02-10 17:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686003002/1
4 years, 10 months ago (2016-02-10 22:44:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 00:06:46 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db034aaf2a2e25138caaff2b5fa1f642460e3d62
Cr-Commit-Position: refs/heads/master@{#374795}

Powered by Google App Engine
This is Rietveld 408576698