Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: net/cert/internal/name_constraints.h

Issue 1685023002: Fix API mismatch between NameConstraints::IsPermittedCert's subjectAltName param and ParseExtension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@name-constraints-directorynameparsing
Patch Set: updated comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/name_constraints.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/name_constraints.h
diff --git a/net/cert/internal/name_constraints.h b/net/cert/internal/name_constraints.h
index 46cb0dade74a34796d7741d572c2c490462ec1aa..ed05de0417beef0397971c4c5fd5e34c71f7227a 100644
--- a/net/cert/internal/name_constraints.h
+++ b/net/cert/internal/name_constraints.h
@@ -86,13 +86,15 @@ class NET_EXPORT NameConstraints {
// Tests if a certificate is allowed by the name constraints.
// |subject_rdn_sequence| should be the DER-encoded value of the subject's
// RDNSequence (not including Sequence tag), and may be an empty ASN.1
- // sequence. |subject_alt_name_extnvalue_tlv| should be the extnValue of the
- // subjectAltName extension (including the OCTET STRING tag & length), or
- // empty if the cert did not have a subjectAltName extension.
+ // sequence. |subject_alt_name_tlv| should be the extnValue of the
+ // subjectAltName extension (not including the OCTET STRING tag & length). If
+ // the cert did not have a subjectAltName extension, |has_subject_alt_name|
+ // should be false and |subject_alt_name_tlv| should be empty.
// Note that this method does not check hostname or IP address in commonName,
// which is deprecated (crbug.com/308330).
bool IsPermittedCert(const der::Input& subject_rdn_sequence,
- const der::Input& subject_alt_name_extnvalue_tlv) const;
+ bool has_subject_alt_name,
+ const der::Input& subject_alt_name_tlv) const;
// Returns true if the ASCII hostname |name| is permitted.
// |name| may be a wildcard hostname (starts with "*."). Eg, "*.bar.com"
« no previous file with comments | « no previous file | net/cert/internal/name_constraints.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698