Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1684993002: Revert of skia: Add support for CHROMIUM_image backed textures. (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of skia: Add support for CHROMIUM_image backed textures. (patchset #19 id:380001 of https://codereview.chromium.org/1623653002/ ) Reason for revert: Breaks ASAN bot: Direct leak of 56 byte(s) in 1 object(s) allocated from: ... test_CustomTexture https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/2676/steps/dm/logs/stdio Original issue's description: > skia: Add support for CHROMIUM_image backed textures. > > I created a new abstract base class TextureStorageAllocator that consumers of > Skia can subclass and pass back to Skia. When a surface is created with a > pointer to a TextureStorageAllocator, any textures it creates, or that are > derived from the original surface, will allocate and deallocate storage using > the methods on TextureStorageAllocator. > > BUG=https://code.google.com/p/chromium/issues/detail?id=579664 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1623653002 > > Committed: https://skia.googlesource.com/skia/+/92098e691f10a010e7421125ba4d44c02506bb55 > > Committed: https://skia.googlesource.com/skia/+/7fec91ce6660190f8d7c5eb6f3061e4550cc672b > > Committed: https://skia.googlesource.com/skia/+/b8d6e088590160f1198110c2371b802c1d541a36 TBR=bsalomon@chromium.org,cblume@chromium.org,bsalomon@google.com,robertphillips@google.com,egdaniel@google.com,reed@google.com,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://code.google.com/p/chromium/issues/detail?id=579664 Committed: https://skia.googlesource.com/skia/+/64e75330916f670cf9db9eb7a850afc325b18645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -323 lines) Patch
M include/core/SkSurface.h View 1 chunk +4 lines, -8 lines 0 comments Download
M include/gpu/GrTypes.h View 4 chunks +3 lines, -61 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +6 lines, -11 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +52 lines, -100 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
D tests/TextureStorageAllocator.cpp View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
caryclark
Created Revert of skia: Add support for CHROMIUM_image backed textures.
4 years, 10 months ago (2016-02-10 00:28:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684993002/1
4 years, 10 months ago (2016-02-10 00:28:37 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 00:28:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/64e75330916f670cf9db9eb7a850afc325b18645

Powered by Google App Engine
This is Rietveld 408576698