Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests. (Closed)

Created:
4 years, 10 months ago by turnidge

Modified:
4 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use Stopwatch instead of DateTime to measure elapsed time in tests. Improve timer_repeat_test.dart to not totally punt on testing the timing. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/be3acab294efe7dd4fcf225bb172c4f6c3fd0c8a

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -22 lines)			Patch
M	tests/isolate/timer_isolate_test.dart	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	tests/lib/async/timer_repeat_test.dart	View		2 chunks	+15 lines, -7 lines	0 comments	Download
M	tests/lib/async/timer_test.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/standalone/io/sleep_test.dart	View	1 2	2 chunks	+10 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

turnidge

4 years, 10 months ago (2016-02-10 19:21:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
be3acab294efe7dd4fcf225bb172c4f6c3fd0c8a (presubmit successful).