Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tests/standalone/io/sleep_test.dart

Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/async/timer_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/sleep_test.dart
diff --git a/tests/standalone/io/sleep_test.dart b/tests/standalone/io/sleep_test.dart
index 795de81f0f02c8130d746254dcb1f6e09d97c5f0..91c662571a0c34fa6f34e7665c87da9521945ac3 100644
--- a/tests/standalone/io/sleep_test.dart
+++ b/tests/standalone/io/sleep_test.dart
@@ -2,15 +2,15 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
import "dart:io";
+import "package:unittest/unittest.dart";
test(int milliseconds) {
var watch = new Stopwatch();
watch.start();
sleep(new Duration(milliseconds: milliseconds));
watch.stop();
- Expect.isTrue(watch.elapsedMilliseconds + 1 >= milliseconds);
+ expect(watch.elapsedMilliseconds, greaterThanOrEqualTo(milliseconds));
}
main() {
@@ -18,6 +18,12 @@ main() {
test(1);
test(10);
test(100);
- Expect.throws(() => sleep(new Duration(milliseconds: -1)),
- (e) => e is ArgumentError);
+ bool sawError = false;
+ try {
+ sleep(new Duration(milliseconds: -1));
+ expect(false, isTrue); // should not reach here.
+ } on ArgumentError catch(e) {
+ sawError = true;
+ }
+ expect(sawError, isTrue);
}
« no previous file with comments | « tests/lib/async/timer_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698