Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: tests/lib/async/timer_repeat_test.dart

Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/isolate/timer_isolate_test.dart ('k') | tests/lib/async/timer_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library timer_repeat_test; 5 library timer_repeat_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 9
10 const Duration TIMEOUT = const Duration(milliseconds: 500); 10 const Duration TIMEOUT = const Duration(milliseconds: 500);
11 const int ITERATIONS = 5; 11 const int ITERATIONS = 5;
12 12
13 Timer timer; 13 Timer timer;
14 int startTime; 14 Stopwatch stopwatch = new Stopwatch();
15 int iteration; 15 int iteration;
16 16
17 // Some browsers (Firefox and IE so far) can trigger too early. Add a safety
18 // margin. We use identical(1, 1.0) as an easy way to know if the test is
19 // compiled by dart2js.
20 int get safetyMargin => identical(1, 1.0) ? 100 : 0;
21
17 void timeoutHandler(Timer timer) { 22 void timeoutHandler(Timer timer) {
18 int endTime = (new DateTime.now()).millisecondsSinceEpoch;
19 iteration++; 23 iteration++;
20 if (iteration < ITERATIONS) { 24 expect(iteration, lessThanOrEqualTo(ITERATIONS));
21 startTime = (new DateTime.now()).millisecondsSinceEpoch; 25 if (iteration == ITERATIONS) {
22 } else { 26 // When we are done with all of the iterations, we expect a
23 expect(iteration, ITERATIONS); 27 // certain amount of time to have passed. Checking the time on
28 // each iteration doesn't work because the timeoutHandler runs
29 // concurrently with the periodic timer.
30 expect(stopwatch.elapsedMilliseconds + safetyMargin,
31 greaterThanOrEqualTo(ITERATIONS * TIMEOUT.inMilliseconds));
24 timer.cancel(); 32 timer.cancel();
25 } 33 }
26 } 34 }
27 35
28 main() { 36 main() {
29 test("timer_repeat", () { 37 test("timer_repeat", () {
30 iteration = 0; 38 iteration = 0;
31 startTime = new DateTime.now().millisecondsSinceEpoch; 39 stopwatch.start();
32 timer = new Timer.periodic(TIMEOUT, 40 timer = new Timer.periodic(TIMEOUT,
33 expectAsync(timeoutHandler, count: ITERATIONS)); 41 expectAsync(timeoutHandler, count: ITERATIONS));
34 }); 42 });
35 } 43 }
OLDNEW
« no previous file with comments | « tests/isolate/timer_isolate_test.dart ('k') | tests/lib/async/timer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698