Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Side by Side Diff: tests/isolate/timer_isolate_test.dart

Issue 1683233003: Use Stopwatch instead of DateTime to measure elapsed time in tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/lib/async/timer_repeat_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library multiple_timer_test; 5 library multiple_timer_test;
6 6
7 import 'dart:isolate'; 7 import 'dart:isolate';
8 import 'dart:async'; 8 import 'dart:async';
9 import 'package:unittest/unittest.dart'; 9 import 'package:unittest/unittest.dart';
10 10
11 const Duration TIMEOUT = const Duration(milliseconds: 100); 11 const Duration TIMEOUT = const Duration(milliseconds: 100);
12 12
13 // Some browsers (Firefox and IE so far) can trigger too early. Add a safety 13 // Some browsers (Firefox and IE so far) can trigger too early. Add a safety
14 // margin. We use identical(1, 1.0) as an easy way to know if the test is 14 // margin. We use identical(1, 1.0) as an easy way to know if the test is
15 // compiled by dart2js. 15 // compiled by dart2js.
16 int get safetyMargin => identical(1, 1.0) ? 100 : 0; 16 int get safetyMargin => identical(1, 1.0) ? 100 : 0;
17 17
18 createTimer(replyTo) { 18 createTimer(replyTo) {
19 new Timer(TIMEOUT, () { 19 new Timer(TIMEOUT, () {
20 replyTo.send("timer_fired"); 20 replyTo.send("timer_fired");
21 }); 21 });
22 } 22 }
23 23
24 main() { 24 main() {
25 test("timer in isolate", () { 25 test("timer in isolate", () {
26 int startTime; 26 Stopwatch stopwatch = new Stopwatch();
27 int endTime;
28
29 ReceivePort port = new ReceivePort(); 27 ReceivePort port = new ReceivePort();
30 28
31 port.first.then(expectAsync((msg) { 29 port.first.then(expectAsync((msg) {
32 expect("timer_fired", msg); 30 expect("timer_fired", msg);
33 int endTime = (new DateTime.now()).millisecondsSinceEpoch; 31 expect(stopwatch.elapsedMilliseconds + safetyMargin,
34 expect(endTime - startTime + safetyMargin, greaterThanOrEqualTo(TIMEOUT.in Milliseconds)); 32 greaterThanOrEqualTo(TIMEOUT.inMilliseconds));
35 })); 33 }));
36 34
37 startTime = (new DateTime.now()).millisecondsSinceEpoch; 35 stopwatch.start();
38 var remote = Isolate.spawn(createTimer, port.sendPort); 36 var remote = Isolate.spawn(createTimer, port.sendPort);
39 }); 37 });
40 } 38 }
OLDNEW
« no previous file with comments | « no previous file | tests/lib/async/timer_repeat_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698