Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener (Closed)

Created:
4 years, 10 months ago by Devlin
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tapted, msramek+watch_chromium.org, Peter Beverloo, Matt Giuca, rouslan+autofill_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, raymes+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI Views] Don't allow a ButtonListener and a MenuButtonListener Step 1 in simplifying our button listener logic (and hopefully removing MenuButtonListener) - ensure each button has at most one listener. BUG=585252 Committed: https://crrev.com/6cd595e5cf64fe3e3a809291fd870f4a8deac1d5 Cr-Commit-Position: refs/heads/master@{#374462}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -120 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 7 chunks +10 lines, -34 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/menu_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/chevron_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/controls/button/menu_button_unittest.cc View 3 chunks +4 lines, -55 lines 0 comments Download
M ui/views/examples/menu_example.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
Scott, mind taking a look? (Note: this did pass trybots on PS1 [which includes https://codereview.chromium.org/1671323002/], ...
4 years, 10 months ago (2016-02-09 00:04:21 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-09 04:55:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682603002/40001
4 years, 10 months ago (2016-02-09 20:04:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-09 20:52:07 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:53:46 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6cd595e5cf64fe3e3a809291fd870f4a8deac1d5
Cr-Commit-Position: refs/heads/master@{#374462}

Powered by Google App Engine
This is Rietveld 408576698