chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc - Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc

Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/browser/ui/views/website_settings/permission_selector_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc

index d28937e8bb9fa03956ae2229750e79527780f90b..bf034bfb5af5ff428634622ea574171d31de28ea 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc

@@ -218,7 +218,7 @@ TEST_F(ToolbarActionViewUnitTest, BasicToolbarActionViewTest) {

EXPECT_FALSE(view.wants_to_run_for_testing());

// Create an overflow button.

- views::MenuButton overflow_button(nullptr, base::string16(), nullptr, false);

+ views::MenuButton overflow_button(base::string16(), nullptr, false);

overflow_button.set_owned_by_client();

action_view_delegate.set_overflow_reference_view(&overflow_button);