chrome/browser/ui/views/menu_model_adapter_test.cc - Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/menu_model_adapter_test.cc

Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc ('k') | chrome/browser/ui/views/menu_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/menu_model_adapter_test.cc

diff --git a/chrome/browser/ui/views/menu_model_adapter_test.cc b/chrome/browser/ui/views/menu_model_adapter_test.cc

index f5fada05591d649af11d63a351e1a95e544bbf5a..78ff30c0ebb96a2ce569c216299c99dd62ac9b71 100644

--- a/chrome/browser/ui/views/menu_model_adapter_test.cc

+++ b/chrome/browser/ui/views/menu_model_adapter_test.cc

@@ -170,8 +170,8 @@ class MenuModelAdapterTest : public ViewEventTestBase,

// ViewEventTestBase implementation.

void SetUp() override {

- button_ = new views::MenuButton(

- NULL, base::ASCIIToUTF16("Menu Adapter Test"), this, true);

+ button_ = new views::MenuButton(base::ASCIIToUTF16("Menu Adapter Test"),

+ this, true);

menu_ = menu_model_adapter_.CreateMenu();

menu_runner_.reset(