ui/message_center/views/notifier_settings_view.cc - Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/notifier_settings_view.cc

Issue 1682603002: [UI Views] Don't allow a ButtonListener and a MenuButtonListener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/message_center/views/notifier_settings_view.cc

diff --git a/ui/message_center/views/notifier_settings_view.cc b/ui/message_center/views/notifier_settings_view.cc

index 145512d886a98193909abfce662180831da91360..dc54bcf11fc6c057a7088229d1a02b82547dc562 100644

--- a/ui/message_center/views/notifier_settings_view.cc

+++ b/ui/message_center/views/notifier_settings_view.cc

@@ -578,7 +578,7 @@ void NotifierSettingsView::UpdateContentsView(

base::string16 notifier_group_text = active_group.login_info.empty() ?

active_group.name : active_group.login_info;

notifier_group_selector_ =

- new views::MenuButton(NULL, notifier_group_text, this, true);

+ new views::MenuButton(notifier_group_text, this, true);

notifier_group_selector_->SetBorder(scoped_ptr<views::Border>(

new views::LabelButtonAssetBorder(views::Button::STYLE_BUTTON)));

notifier_group_selector_->SetFocusPainter(nullptr);

« no previous file with comments | « ui/app_list/views/search_box_view.cc ('k') | ui/views/controls/button/custom_button_unittest.cc » ('j') | no next file with comments »