Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1681393006: Use UrlRequest in PortAllocator. (Closed)

Created:
4 years, 10 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UrlRequest in PortAllocator. PepperPortAllocator and ChromiumPortAllocator were different only in how they were sending HTTP requests to allocate relay session. They were using pp::URLLoader and net::URLFetcher respectively, but otherwise contained largely the same logic. Now URL request logic is abstracted with remoting::UrlRequest interface and so a single PortAllocator implementation can be used in all cases. BUG=577954 Committed: https://crrev.com/c3c43e8732254dedcbd313629f8c9eba93dff6fa Cr-Commit-Position: refs/heads/master@{#375042}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -841 lines) Patch
M remoting/client/jni/chromoting_jni_instance.cc View 1 2 3 chunks +8 lines, -10 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +4 lines, -1 line 0 comments Download
D remoting/client/plugin/pepper_port_allocator.h View 1 chunk +0 lines, -60 lines 0 comments Download
D remoting/client/plugin/pepper_port_allocator.cc View 1 chunk +0 lines, -197 lines 0 comments Download
A remoting/client/plugin/pepper_port_allocator_factory.h View 1 chunk +33 lines, -0 lines 0 comments Download
A remoting/client/plugin/pepper_port_allocator_factory.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 3 chunks +4 lines, -2 lines 0 comments Download
D remoting/protocol/chromium_port_allocator.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/protocol/chromium_port_allocator.cc View 1 chunk +0 lines, -140 lines 0 comments Download
A remoting/protocol/chromium_port_allocator_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A remoting/protocol/chromium_port_allocator_factory.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M remoting/protocol/ice_transport_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/protocol/port_allocator.h View 1 4 chunks +23 lines, -30 lines 0 comments Download
A + remoting/protocol/port_allocator.cc View 7 chunks +48 lines, -26 lines 0 comments Download
D remoting/protocol/port_allocator_base.h View 1 chunk +0 lines, -85 lines 0 comments Download
D remoting/protocol/port_allocator_base.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M remoting/protocol/port_allocator_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/transport_context.h View 4 chunks +6 lines, -3 lines 0 comments Download
M remoting/protocol/transport_context.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M remoting/protocol/webrtc_transport.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_transport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
Sergey Ulanov
4 years, 10 months ago (2016-02-10 23:41:59 UTC) #6
Jamie
lgtm
4 years, 10 months ago (2016-02-11 02:22:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681393006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681393006/80001
4 years, 10 months ago (2016-02-11 21:49:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/20999)
4 years, 10 months ago (2016-02-11 22:41:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681393006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681393006/100001
4 years, 10 months ago (2016-02-11 23:04:27 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 10 months ago (2016-02-11 23:47:10 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:39:32 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c3c43e8732254dedcbd313629f8c9eba93dff6fa
Cr-Commit-Position: refs/heads/master@{#375042}

Powered by Google App Engine
This is Rietveld 408576698