Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: remoting/client/jni/chromoting_jni_instance.cc

Issue 1681393006: Use UrlRequest in PortAllocator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/chromoting_jni_instance.cc
diff --git a/remoting/client/jni/chromoting_jni_instance.cc b/remoting/client/jni/chromoting_jni_instance.cc
index e7bd0e34121f473c49582ec75d10c426784f067b..678db65d14a835f1ad5bda6b38104a26917fc70b 100644
--- a/remoting/client/jni/chromoting_jni_instance.cc
+++ b/remoting/client/jni/chromoting_jni_instance.cc
@@ -13,6 +13,7 @@
#include "base/logging.h"
#include "jingle/glue/thread_wrapper.h"
#include "net/socket/client_socket_factory.h"
+#include "remoting/base/chromium_url_request.h"
#include "remoting/base/service_urls.h"
#include "remoting/client/audio_player.h"
#include "remoting/client/client_status_logger.h"
@@ -21,7 +22,7 @@
#include "remoting/client/jni/jni_frame_consumer.h"
#include "remoting/client/software_video_renderer.h"
#include "remoting/client/token_fetcher_proxy.h"
-#include "remoting/protocol/chromium_port_allocator.h"
+#include "remoting/protocol/chromium_port_allocator_factory.h"
#include "remoting/protocol/chromium_socket_factory.h"
#include "remoting/protocol/host_stub.h"
#include "remoting/protocol/negotiating_client_authenticator.h"
@@ -424,17 +425,14 @@ void ChromotingJniInstance::ConnectToHostOnNetworkThread() {
signaling_.get(),
ServiceUrls::GetInstance()->directory_bot_jid()));
- protocol::NetworkSettings network_settings(
- protocol::NetworkSettings::NAT_TRAVERSAL_FULL);
-
- // Use Chrome's network stack to allocate ports for peer-to-peer channels.
- scoped_ptr<protocol::ChromiumPortAllocatorFactory> port_allocator_factory(
- new protocol::ChromiumPortAllocatorFactory(
- jni_runtime_->url_requester()));
-
scoped_refptr<protocol::TransportContext> transport_context =
new protocol::TransportContext(
- signaling_.get(), std::move(port_allocator_factory), network_settings,
+ signaling_.get(),
+ make_scoped_ptr(new protocol::ChromiumPortAllocatorFactory()),
+ make_scoped_ptr(
+ new ChromiumUrlRequestFactory(jni_runtime_->url_requester())),
+ protocol::NetworkSettings(
+ protocol::NetworkSettings::NAT_TRAVERSAL_FULL),
protocol::TransportRole::CLIENT);
if (flags_.find("useWebrtc") != std::string::npos) {
« no previous file with comments | « no previous file | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698