Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Issue 1679023009: Add remoting::UrlRequest interface with 2 implementations (Closed)

Created:
4 years, 10 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting::UrlRequest interface with 2 implementations PepperPortAllocator and ChromiumPortAllocator are largely the same but use different APIs to sent HTTP requests to allocate relay session. Specifically they use pp::URLLoader and net::URLFetcher respectively. This CL adds an abstract interface for URL request with two implementations: - PepperUrlRequest - to be used in the plugin, - ChromiumUrlRequest - to be used everywhere else. BUG=577954 Committed: https://crrev.com/9b3d516c34b2ffe9ea4b4c40102dd14eb8f04a3f Cr-Commit-Position: refs/heads/master@{#374975}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -1 line) Patch
M remoting/base/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A remoting/base/chromium_url_request.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A remoting/base/chromium_url_request.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
A remoting/base/url_request.h View 1 chunk +58 lines, -0 lines 0 comments Download
A remoting/client/plugin/pepper_url_request.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A remoting/client/plugin/pepper_url_request.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Sergey Ulanov
4 years, 10 months ago (2016-02-10 23:39:42 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1679023009/diff/1/remoting/base/chromium_url_request.cc File remoting/base/chromium_url_request.cc (right): https://codereview.chromium.org/1679023009/diff/1/remoting/base/chromium_url_request.cc#newcode43 remoting/base/chromium_url_request.cc:43: base::ResetAndReturn(&on_result_callback_).Run(result); CHECK the callback isn't null? https://codereview.chromium.org/1679023009/diff/1/remoting/base/chromium_url_request.h File ...
4 years, 10 months ago (2016-02-11 01:58:45 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1679023009/diff/1/remoting/base/chromium_url_request.cc File remoting/base/chromium_url_request.cc (right): https://codereview.chromium.org/1679023009/diff/1/remoting/base/chromium_url_request.cc#newcode43 remoting/base/chromium_url_request.cc:43: base::ResetAndReturn(&on_result_callback_).Run(result); On 2016/02/11 01:58:44, Jamie wrote: > CHECK the ...
4 years, 10 months ago (2016-02-11 18:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679023009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679023009/20001
4 years, 10 months ago (2016-02-11 18:59:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/124098) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-11 19:19:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679023009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679023009/40001
4 years, 10 months ago (2016-02-11 19:40:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 20:58:22 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:37:48 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9b3d516c34b2ffe9ea4b4c40102dd14eb8f04a3f
Cr-Commit-Position: refs/heads/master@{#374975}

Powered by Google App Engine
This is Rietveld 408576698