Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 1681003002: ARM32 vector division lowering. (Closed)

Created:
4 years, 10 months ago by Eric Holk
Modified:
4 years, 10 months ago
Reviewers:
Jim Stichnoth, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -42 lines) Patch
M src/IceInstARM32.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLowering.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 3 chunks +15 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/IceTypes.def View 1 chunk +1 line, -1 line 0 comments Download
A tests_lit/assembler/arm32/udiv-vec.ll View 1 chunk +246 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Eric Holk
This works by scalarizing division. I refactored the existing X86 scalarization code into something that ...
4 years, 10 months ago (2016-02-09 01:07:46 UTC) #2
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-10 01:36:11 UTC) #3
Eric Holk
4 years, 10 months ago (2016-02-10 01:48:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfc25533574c4636a53089622a478ecbda9b4daf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698