Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1680593004: dart:developer service extension fixes (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart:developer service extension fixes Fixes #25724 Fixes Florian Loitsch's emailed request (get rid of k prefix on constants). - Rename ServiceExtensionResponse constants to not have a 'k' prefix. - Provide more explanation on how to invoke service extensions (they require an 'isolateId' parameter). - Require extension method names to begin with "ext." and recommend the template: "ext.package.command" to avoid conflicts with other packages. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b9b0649b9cfe11c8dc62edfd5606c4790c793d3a

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -76 lines) Patch
M runtime/bin/process_patch.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/developer_extension_test.dart View 1 2 3 5 chunks +32 lines, -32 lines 0 comments Download
M runtime/observatory/tests/service/file_service_test.dart View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/process_service_test.dart View 1 2 3 2 chunks +12 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_closing_service_test.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/udp_socket_service_test.dart View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/developer/extension.dart View 1 2 3 2 chunks +29 lines, -6 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 10 months ago (2016-02-09 02:15:41 UTC) #3
rmacnak
lgtm
4 years, 10 months ago (2016-02-09 18:32:21 UTC) #4
Cutch
4 years, 10 months ago (2016-02-10 16:54:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b9b0649b9cfe11c8dc62edfd5606c4790c793d3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698