Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: runtime/observatory/tests/service/udp_socket_service_test.dart

Issue 1680593004: dart:developer service extension fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/tcp_socket_service_test.dart ('k') | sdk/lib/developer/extension.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/udp_socket_service_test.dart
diff --git a/runtime/observatory/tests/service/udp_socket_service_test.dart b/runtime/observatory/tests/service/udp_socket_service_test.dart
index 49ff5e4fc1d0af72dbe67f498039dae538946587..6a6a0e020e47a10ef7568d1d4c28a6ce00c2abc2 100644
--- a/runtime/observatory/tests/service/udp_socket_service_test.dart
+++ b/runtime/observatory/tests/service/udp_socket_service_test.dart
@@ -25,7 +25,8 @@ Future setupUDP() async {
var udpTests = [
// Initial.
(Isolate isolate) async {
- var result = await isolate.invokeRpcNoUpgrade('__getOpenSockets', {});
+ var result =
+ await isolate.invokeRpcNoUpgrade('ext.dart.io.getOpenSockets', {});
expect(result['type'], equals('_opensockets'));
// We expect 2 sockets to be open (in this order):
// The server socket accepting connections, on port X
@@ -38,7 +39,7 @@ var udpTests = [
expect(result['data'][1]['name'].startsWith('127.0.0.1:'), isTrue);
var server = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][0]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][0]['id'] });
expect(server['id'], equals(result['data'][0]['id']));
expect(server['remotePort'], equals('NA'));
expect(server['remoteHost'], equals('NA'));
@@ -58,7 +59,7 @@ var udpTests = [
expect(server['readCount'], greaterThanOrEqualTo(1));
var client = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][1]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][1]['id'] });
expect(client['id'], equals(result['data'][1]['id']));
expect(client['remotePort'], equals('NA'));
expect(client['remoteHost'], equals('NA'));
« no previous file with comments | « runtime/observatory/tests/service/tcp_socket_service_test.dart ('k') | sdk/lib/developer/extension.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698