Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: runtime/observatory/tests/service/file_service_test.dart

Issue 1680593004: dart:developer service extension fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/file_service_test.dart
diff --git a/runtime/observatory/tests/service/file_service_test.dart b/runtime/observatory/tests/service/file_service_test.dart
index 22b58272b9d59657863c190105f4e8c00914ec05..25500c665f8980fdfc96932dc8ec1eadc48903b0 100644
--- a/runtime/observatory/tests/service/file_service_test.dart
+++ b/runtime/observatory/tests/service/file_service_test.dart
@@ -64,20 +64,21 @@ Future setupFiles() async {
var result = JSON.encode({'type' : 'foobar'});
return new Future.value(new ServiceExtensionResponse.result(result));
}
- registerExtension('__cleanup', cleanup);
- registerExtension('__setup', setup);
+ registerExtension('ext.dart.io.cleanup', cleanup);
+ registerExtension('ext.dart.io.setup', setup);
}
var fileTests = [
(Isolate isolate) async {
- await isolate.invokeRpcNoUpgrade('__setup', {});
+ await isolate.invokeRpcNoUpgrade('ext.dart.io.setup', {});
try {
- var result = await isolate.invokeRpcNoUpgrade('__getOpenFiles', {});
+ var result =
+ await isolate.invokeRpcNoUpgrade('ext.dart.io.getOpenFiles', {});
expect(result['type'], equals('_openfiles'));
expect(result['data'].length, equals(2));
var writing = await isolate.invokeRpcNoUpgrade(
- '__getFileByID', { 'id' : result['data'][0]['id'] });
+ 'ext.dart.io.getFileByID', { 'id' : result['data'][0]['id'] });
expect(writing['totalRead'], equals(0));
expect(writing['readCount'], equals(0));
@@ -87,7 +88,7 @@ var fileTests = [
expect(writing['lastRead'], equals(0));
var reading = await isolate.invokeRpcNoUpgrade(
- '__getFileByID', { 'id' : result['data'][1]['id'] });
+ 'ext.dart.io.getFileByID', { 'id' : result['data'][1]['id'] });
expect(reading['totalRead'], equals(5));
expect(reading['readCount'], equals(5));
@@ -97,7 +98,7 @@ var fileTests = [
expect(reading['lastRead'], greaterThan(0));
} finally {
- await isolate.invokeRpcNoUpgrade('__cleanup', {});
+ await isolate.invokeRpcNoUpgrade('ext.dart.io.cleanup', {});
}
},
];

Powered by Google App Engine
This is Rietveld 408576698