dart:developer service extension fixes

runtime/observatory/tests/service/tcp_socket_service_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io' as io;
 import 'package:observatory/service_io.dart';
 import 'package:unittest/unittest.dart';
 import 'test_helper.dart';
@@ skipping 12 matching lines @@
   await socket.flush();
 
   var socket2 = await io.Socket.connect("127.0.0.1", serverSocket.port);
   socket2.write("foobarfoobar");
   await socket2.flush();
 }
 
 var tcpTests = [
   // Initial.
   (Isolate isolate) async {
-    var result = await isolate.invokeRpcNoUpgrade('__getOpenSockets', {});
+    var result =
+            await isolate.invokeRpcNoUpgrade('ext.dart.io.getOpenSockets', {});
     expect(result['type'], equals('_opensockets'));
     // We expect 3 sockets to be open (in this order):
     //   The server socket accepting connections, on port X
     //   The accepted connection on the client, on port Y
     //   The client connection, on port X
     if (result['data'].length != 5) {
       print(result['data']);
     }
     expect(result['data'].length, equals(5));
     // The first socket will have a name like listening:127.0.0.1:X
     // The second will have a name like 127.0.0.1:Y
     // The third will have a name like 127.0.0.1:X
     expect(result['data'][0]['name'].startsWith('listening:127.0.0.1'), isTrue);
     expect(result['data'][1]['name'].startsWith('127.0.0.1:'), isTrue);
     expect(result['data'][2]['name'].startsWith('127.0.0.1:'), isTrue);
 
     var listening = await isolate.invokeRpcNoUpgrade(
-        '__getSocketByID', { 'id' : result['data'][0]['id'] });
+        'ext.dart.io.getSocketByID', { 'id' : result['data'][0]['id'] });
     expect(listening['id'], equals(result['data'][0]['id']));
     expect(listening['listening'], isTrue);
     expect(listening['socketType'], equals('TCP'));
     expect(listening['port'], greaterThanOrEqualTo(1024));
     expect(listening['lastRead'], greaterThan(0));
 
     expect(listening['totalRead'], equals(2));
     expect(listening['lastWrite'], equals(0));
     expect(listening['totalWritten'], equals(0));
     expect(listening['writeCount'], equals(0));
     expect(listening['readCount'], equals(2));
     expect(listening['remoteHost'], equals('NA'));
     expect(listening['remotePort'], equals('NA'));
 
     var client = await isolate.invokeRpcNoUpgrade(
-        '__getSocketByID', { 'id' : result['data'][1]['id'] });
+        'ext.dart.io.getSocketByID', { 'id' : result['data'][1]['id'] });
     expect(client['id'], equals(result['data'][1]['id']));
 
     var server = await isolate.invokeRpcNoUpgrade(
-        '__getSocketByID', { 'id' : result['data'][2]['id'] });
+        'ext.dart.io.getSocketByID', { 'id' : result['data'][2]['id'] });
     expect(server['id'], equals(result['data'][2]['id']));
 
     // We expect the client to be connected on the port and
     // host of the listening socket.
     expect(client['remotePort'], equals(listening['port']));
     expect(client['remoteHost'], equals(listening['host']));
     // We expect the third socket (accepted server) to be connected to the
     // same port and host as the listening socket (the listening one).
     expect(server['port'], equals(listening['port']));
     expect(server['host'], equals(listening['host']));
@@ skipping 26 matching lines @@
 
     // Order
     // Stopwatch resolution on windows can make us have the same timestamp.
     if (io.Platform.isWindows) {
       expect(server['lastRead'], greaterThanOrEqualTo(client['lastWrite']));
     } else {
       expect(server['lastRead'], greaterThan(client['lastWrite']));
     }
 
     var secondClient = await isolate.invokeRpcNoUpgrade(
-        '__getSocketByID', { 'id' : result['data'][3]['id'] });
+        'ext.dart.io.getSocketByID', { 'id' : result['data'][3]['id'] });
     expect(secondClient['id'], equals(result['data'][3]['id']));
     var secondServer = await isolate.invokeRpcNoUpgrade(
-        '__getSocketByID', { 'id' : result['data'][4]['id'] });
+        'ext.dart.io.getSocketByID', { 'id' : result['data'][4]['id'] });
     expect(secondServer['id'], equals(result['data'][4]['id']));
 
     // We expect the client to be connected on the port and
     // host of the listening socket.
     expect(secondClient['remotePort'], equals(listening['port']));
     expect(secondClient['remoteHost'], equals(listening['host']));
     // We expect the third socket (accepted server) to be connected to the
     // same port and host as the listening socket (the listening one).
     expect(secondServer['port'], equals(listening['port']));
     expect(secondServer['host'], equals(listening['host']));
@@ skipping 28 matching lines @@
     // Stopwatch resolution on windows make us sometimes report the same value.
     if (io.Platform.isWindows) {
       expect(server['lastRead'], greaterThanOrEqualTo(client['lastWrite']));
     } else {
       expect(server['lastRead'], greaterThan(client['lastWrite']));
     }
   },
 ];
 
 main(args) async => runIsolateTests(args, tcpTests, testeeBefore:setupTCP);