cpsir: triage remainder of html test suite, fix a couple.

cpsir: triage remainder of html test suite, fix a couple.

R=asgerf@google.com, het@google.com

Committed: https://github.com/dart-lang/sdk/commit/c3e61f315c18d1f9800192729717ac8d34b1b7f0

[Siggi Cherem (dart-lang), 2016-02-06 02:36:26]

sigmund@google.com changed reviewers:
+ asgerf@google.com, het@google.com

[Siggi Cherem (dart-lang), 2016-02-06 02:36:27]

https://codereview.chromium.org/1679603002/diff/1/sdk/lib/html/dart2js/html_d...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1679603002/diff/1/sdk/lib/html/dart2js/html_d...
sdk/lib/html/dart2js/html_dart2js.dart:15419: + 
@Returns('EventTarget|=Object|Null')
we didn't take advantage of these effects in SSA - so they only showed up as
issues in CPS. 

These changes fix keyboard_event & mouse_event tests

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status
File tests/html/html.status (left):

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status#oldc...
tests/html/html.status:431: keyboard_event_test: RuntimeError # Please triage
Sorry for the noise from sorting. I'll highlight the missing entries here.

This one is gone (fixed by the change in the effects declaration)

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status#oldc...
tests/html/html.status:442: input_element_test/attributes: Pass # Please triage
I changed the tests slightly to make this one fail consistently between ssa &
cps (it was purposely failing on ssa)

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status#oldc...
tests/html/html.status:450: mouse_event_test: RuntimeError # Please triage
gone (fixed)

https://codereview.chromium.org/1679603002/diff/1/tests/html/input_element_te...
File tests/html/input_element_test.dart (left):

https://codereview.chromium.org/1679603002/diff/1/tests/html/input_element_te...
tests/html/input_element_test.dart:190: e.value = list[0];
we replaced this with null, but SSA didn't, the new code consistently makes this
undefined.

[Siggi Cherem (dart-lang), 2016-02-06 02:40:06]

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/1679603002/diff/1/tests/html/html.status#newc...
tests/html/html.status:455: js_test/Dart_functions: RuntimeError # Bad code for
new #(). Issue #25708, also we seem to tree-shake a closure that escapes to
js-interop
looking closer into this one, I believe that only the escaping issue is causing
this failure. I'll file a bug for it.

[asgerf, 2016-02-08 08:47:05]

lgtm

[Harry Terkelsen, 2016-02-08 17:27:21]

lgtm

[Siggi Cherem (dart-lang), 2016-02-08 18:37:56]

Description was changed from

==========
cpsir: triage remainder of html test suite, fix a couple.
==========

to

==========
cpsir: triage remainder of html test suite, fix a couple.

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c3e61f315c18d1f9800192729717ac8d34b1b7f0
==========

[Siggi Cherem (dart-lang), 2016-02-08 18:37:58]

Committed patchset #1 (id:1) manually as
c3e61f315c18d1f9800192729717ac8d34b1b7f0 (presubmit successful).