sdk/lib/html/dart2js/html_dart2js.dart - Issue 1679603002: cpsir: triage remainder of html test suite, fix a couple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 1679603002: cpsir: triage remainder of html test suite, fix a couple. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 88d2b88c86f1089f9d024c72fb6b1f14627fea11..25dce9d907caed58d2853ac2eb9d8007692b7d2f 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -15416,7 +15416,7 @@ class Event extends Interceptor {

@DomName('Event.currentTarget')

@DocsEditable()

@Creates('Null')

- @Returns('EventTarget|=Object')

+ @Returns('EventTarget|=Object|Null')

Siggi Cherem (dart-lang) 2016/02/06 02:36:27 we didn't take advantage of these effects in SSA -

final dynamic _get_currentTarget;

@DomName('Event.defaultPrevented')

@@ -15451,7 +15451,7 @@ class Event extends Interceptor {

@DomName('Event.target')

@DocsEditable()

@Creates('Node')

- @Returns('EventTarget|=Object')

+ @Returns('EventTarget|=Object|Null')

final dynamic _get_target;

@DomName('Event.timeStamp')

@@ -22962,7 +22962,7 @@ class MouseEvent extends UIEvent {

@DomName('MouseEvent.relatedTarget')

@DocsEditable()

@Creates('Node')

- @Returns('EventTarget|=Object')

+ @Returns('EventTarget|=Object|Null')

final dynamic _get_relatedTarget;

@JSName('screenX')

« no previous file with comments | « no previous file | tests/html/html.status » ('j') | tests/html/html.status » ('J')