Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: tests/html/input_element_test.dart

Issue 1679603002: cpsir: triage remainder of html test suite, fix a couple. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/html/input_element_test.dart
diff --git a/tests/html/input_element_test.dart b/tests/html/input_element_test.dart
index 0a12d0ba642299bc240f3ab506a179473bb722e2..9509e02ca67d66d4ee4b12ecf0bd6daed3b898f1 100644
--- a/tests/html/input_element_test.dart
+++ b/tests/html/input_element_test.dart
@@ -186,9 +186,10 @@ main() {
});
test('valueSetNullProxy', () {
final e = new TextInputElement();
- var list = new List(5);
- e.value = list[0];
Siggi Cherem (dart-lang) 2016/02/06 02:36:27 we replaced this with null, but SSA didn't, the ne
+ e.value = _undefined;
expect(e.value, '');
});
});
}
+
+var _undefined = (() => new List(5)[0])();

Powered by Google App Engine
This is Rietveld 408576698